diff options
author | Yang Yingliang <yangyingliang@huawei.com> | 2022-10-31 20:13:40 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2022-11-02 12:34:48 +0000 |
commit | e7d1d4d9ac0dfa40be4c2c8abd0731659869b297 (patch) | |
tree | a75a419d62c22acad066f6cfad7f3dfe9b0e1377 | |
parent | e97c089d7a49f67027395ddf70bf327eeac2611e (diff) | |
download | lwn-e7d1d4d9ac0dfa40be4c2c8abd0731659869b297.tar.gz lwn-e7d1d4d9ac0dfa40be4c2c8abd0731659869b297.zip |
mISDN: fix possible memory leak in mISDN_register_device()
Afer commit 1fa5ae857bb1 ("driver core: get rid of struct device's
bus_id string array"), the name of device is allocated dynamically,
add put_device() to give up the reference, so that the name can be
freed in kobject_cleanup() when the refcount is 0.
Set device class before put_device() to avoid null release() function
WARN message in device_release().
Fixes: 1fa5ae857bb1 ("driver core: get rid of struct device's bus_id string array")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/isdn/mISDN/core.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/isdn/mISDN/core.c b/drivers/isdn/mISDN/core.c index a41b4b264594..7ea0100f218a 100644 --- a/drivers/isdn/mISDN/core.c +++ b/drivers/isdn/mISDN/core.c @@ -233,11 +233,12 @@ mISDN_register_device(struct mISDNdevice *dev, if (debug & DEBUG_CORE) printk(KERN_DEBUG "mISDN_register %s %d\n", dev_name(&dev->dev), dev->id); + dev->dev.class = &mISDN_class; + err = create_stack(dev); if (err) goto error1; - dev->dev.class = &mISDN_class; dev->dev.platform_data = dev; dev->dev.parent = parent; dev_set_drvdata(&dev->dev, dev); @@ -249,8 +250,8 @@ mISDN_register_device(struct mISDNdevice *dev, error3: delete_stack(dev); - return err; error1: + put_device(&dev->dev); return err; } |