diff options
| author | Loc Ho <lho@apm.com> | 2015-09-24 10:38:07 -0700 |
|---|---|---|
| committer | Borislav Petkov <bp@suse.de> | 2015-09-25 15:39:52 +0200 |
| commit | 9bc1c0c0ec14dcdb6df2c7a39dbaecb383a46681 (patch) | |
| tree | af30312f20b9fe54d2b7e9ff1170988f32517250 | |
| parent | 9347473c7d8218c795b5a73d8d94aa53657d9e29 (diff) | |
| download | lwn-9bc1c0c0ec14dcdb6df2c7a39dbaecb383a46681.tar.gz lwn-9bc1c0c0ec14dcdb6df2c7a39dbaecb383a46681.zip | |
EDAC, xgene: Fix possible sprintf() overflow issue
Replace sprintf() with snprintf() to avoid possible string array
overflow.
Signed-off-by: Loc Ho <lho@apm.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: devicetree@vger.kernel.org
Cc: ijc+devicetree@hellion.org.uk
Cc: jcm@redhat.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-edac <linux-edac@vger.kernel.org>
Cc: mark.rutland@arm.com
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: patches@apm.com
Cc: robh+dt@kernel.org
Link: http://lkml.kernel.org/r/1443116287-11752-1-git-send-email-lho@apm.com
Signed-off-by: Borislav Petkov <bp@suse.de>
| -rw-r--r-- | drivers/edac/xgene_edac.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c index aee03c21632a..dfa13bb60d71 100644 --- a/drivers/edac/xgene_edac.c +++ b/drivers/edac/xgene_edac.c @@ -879,7 +879,7 @@ xgene_edac_pmd_create_debugfs_nodes(struct edac_device_ctl_info *edac_dev) if (!IS_ENABLED(CONFIG_EDAC_DEBUG) || !ctx->edac->dfs) return; - sprintf(name, "PMD%d", ctx->pmd); + snprintf(name, sizeof(name), "PMD%d", ctx->pmd); dbgfs_dir = edac_debugfs_create_dir_at(name, ctx->edac->dfs); if (!dbgfs_dir) return; @@ -923,7 +923,7 @@ static int xgene_edac_pmd_add(struct xgene_edac *edac, struct device_node *np, goto err_group; } - sprintf(edac_name, "l2c%d", pmd); + snprintf(edac_name, sizeof(edac_name), "l2c%d", pmd); edac_dev = edac_device_alloc_ctl_info(sizeof(*ctx), edac_name, 1, "l2c", 1, 2, NULL, 0, edac_device_alloc_index()); |