diff options
| author | Pan Bian <bianpan2016@163.com> | 2016-12-04 18:43:31 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-12-05 15:03:42 -0500 |
| commit | 9a53682b340b97642793271ba095cc9531a7b649 (patch) | |
| tree | f72523e98bfd2ae3bf01591ee6bf6d29d1c49e75 | |
| parent | 005f7e68e74df94c2a676b5a3e98c6fb65aae606 (diff) | |
| download | lwn-9a53682b340b97642793271ba095cc9531a7b649.tar.gz lwn-9a53682b340b97642793271ba095cc9531a7b649.zip | |
isdn: hisax: set error code on failure
In function hfc4s8s_probe(), the value of return variable err should be
negative on failures. However, when the call to request_region() returns
NULL, the value of err is 0. This patch fixes the bug, assigning
"-EBUSY" to err on the path that request_region() fails.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188931
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/isdn/hisax/hfc4s8s_l1.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/isdn/hisax/hfc4s8s_l1.c b/drivers/isdn/hisax/hfc4s8s_l1.c index 9600cd771f1a..e034ed847ff3 100644 --- a/drivers/isdn/hisax/hfc4s8s_l1.c +++ b/drivers/isdn/hisax/hfc4s8s_l1.c @@ -1499,6 +1499,7 @@ hfc4s8s_probe(struct pci_dev *pdev, const struct pci_device_id *ent) printk(KERN_INFO "HFC-4S/8S: failed to request address space at 0x%04x\n", hw->iobase); + err = -EBUSY; goto out; } |