summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Lebrun <david.lebrun@uclouvain.be>2017-04-19 16:10:19 +0200
committerDavid S. Miller <davem@davemloft.net>2017-04-21 13:16:01 -0400
commit95b9b88d2da5e43e025400afcb492643933bf858 (patch)
tree40a417e9a20e0c91db886b8f873d7cbade9c656d
parentb0522e13b2e6266ac00dc579b79fbfee22753293 (diff)
downloadlwn-95b9b88d2da5e43e025400afcb492643933bf858.tar.gz
lwn-95b9b88d2da5e43e025400afcb492643933bf858.zip
ipv6: sr: fix double free of skb after handling invalid SRH
The icmpv6_param_prob() function already does a kfree_skb(), this patch removes the duplicate one. Fixes: 1ababeba4a21f3dba3da3523c670b207fb2feb62 ("ipv6: implement dataplane support for rthdr type 4 (Segment Routing Header)") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: David Lebrun <david.lebrun@uclouvain.be> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv6/exthdrs.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c
index 275cac628a95..25192a3b0cd7 100644
--- a/net/ipv6/exthdrs.c
+++ b/net/ipv6/exthdrs.c
@@ -388,7 +388,6 @@ looped_back:
icmpv6_param_prob(skb, ICMPV6_HDR_FIELD,
((&hdr->segments_left) -
skb_network_header(skb)));
- kfree_skb(skb);
return -1;
}