diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2016-10-22 12:32:04 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-10-26 17:21:59 -0400 |
| commit | 1aaa87aff688bbb47e9ab36c638e1bb876810a39 (patch) | |
| tree | 309af29b7bd37b593a43b49bbb6a83dd5daa1f44 | |
| parent | 701470babace4c4bbcc8463a5609790f91f85bdb (diff) | |
| download | lwn-1aaa87aff688bbb47e9ab36c638e1bb876810a39.tar.gz lwn-1aaa87aff688bbb47e9ab36c638e1bb876810a39.zip | |
net: netcp: drop kfree for memory allocated with devm_kzalloc
It's not necessary to free memory allocated with devm_kzalloc in the
remove path and using kfree leads to a double free.
Fixes: 84640e27f230 ("net: netcp: Add Keystone NetCP core ethernet
driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/ti/netcp_core.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c index 11609d5467fc..2fb5b6dd5231 100644 --- a/drivers/net/ethernet/ti/netcp_core.c +++ b/drivers/net/ethernet/ti/netcp_core.c @@ -2058,7 +2058,6 @@ static void netcp_delete_interface(struct netcp_device *netcp_device, if (module->release) module->release(intf_modpriv->module_priv); list_del(&intf_modpriv->intf_list); - kfree(intf_modpriv); } WARN(!list_empty(&netcp->module_head), "%s interface module list is not empty!\n", ndev->name); @@ -2153,7 +2152,6 @@ static int netcp_remove(struct platform_device *pdev) dev_dbg(&pdev->dev, "Removing module \"%s\"\n", module->name); module->remove(netcp_device, inst_modpriv->module_priv); list_del(&inst_modpriv->inst_list); - kfree(inst_modpriv); } /* now that all modules are removed, clean up the interfaces */ |