diff options
| author | Anup Sharma <anupnewsmail@gmail.com> | 2023-05-13 01:54:34 +0530 |
|---|---|---|
| committer | Jon Mason <jdmason@kudzu.us> | 2023-07-08 13:55:44 -0400 |
| commit | bff6efc54bd0e27a332eb733525d7f698fd4a5b7 (patch) | |
| tree | e076c5e05e6c9c50aec2409bb75c129429fcecdd | |
| parent | 48063dfa4fbb4b5aac3d8aacbf1fd1170b51c5fa (diff) | |
| download | lwn-bff6efc54bd0e27a332eb733525d7f698fd4a5b7.tar.gz lwn-bff6efc54bd0e27a332eb733525d7f698fd4a5b7.zip | |
ntb: hw: amd: Fix debugfs_create_dir error checking
The debugfs_create_dir function returns ERR_PTR in case of error, and the
only correct way to check if an error occurred is 'IS_ERR' inline function.
This patch will replace the null-comparison with IS_ERR.
Signed-off-by: Anup Sharma <anupnewsmail@gmail.com>
Suggested-by: Ivan Orlov <ivan.orlov0322@gmail.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
| -rw-r--r-- | drivers/ntb/hw/amd/ntb_hw_amd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ntb/hw/amd/ntb_hw_amd.c b/drivers/ntb/hw/amd/ntb_hw_amd.c index 855ff65f64a5..4940b6301d83 100644 --- a/drivers/ntb/hw/amd/ntb_hw_amd.c +++ b/drivers/ntb/hw/amd/ntb_hw_amd.c @@ -941,7 +941,7 @@ static void ndev_init_debugfs(struct amd_ntb_dev *ndev) ndev->debugfs_dir = debugfs_create_dir(pci_name(ndev->ntb.pdev), debugfs_dir); - if (!ndev->debugfs_dir) + if (IS_ERR(ndev->debugfs_dir)) ndev->debugfs_info = NULL; else ndev->debugfs_info = |