diff options
| author | Tejun Heo <tj@kernel.org> | 2015-09-29 12:47:51 -0400 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2015-10-12 10:31:11 -0600 |
| commit | 6fdf860f15d4a6be8f0947bad608d687fe0c7af7 (patch) | |
| tree | 817c55df41afb26f6c0aaa98f3e9ce6952872c22 | |
| parent | 9ad18ab938375502c03cf467abecbb77264c9475 (diff) | |
| download | lwn-6fdf860f15d4a6be8f0947bad608d687fe0c7af7.tar.gz lwn-6fdf860f15d4a6be8f0947bad608d687fe0c7af7.zip | |
writeback: fix bdi_writeback iteration in wakeup_dirtytime_writeback()
wakeup_dirtytime_writeback() walks and wakes up all wb's of all bdi's;
unfortunately, it was always waking up bdi->wb instead of the wb being
walked. Fix it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Fixes: 001fe6f617b1 ("writeback: make wakeup_dirtytime_writeback() handle multiple bdi_writeback's")
Reviewed-by: Jan Kara <jack@suse.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
| -rw-r--r-- | fs/fs-writeback.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 091a36444972..d0da30668e98 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -1897,8 +1897,8 @@ static void wakeup_dirtytime_writeback(struct work_struct *w) struct wb_iter iter; bdi_for_each_wb(wb, bdi, &iter, 0) - if (!list_empty(&bdi->wb.b_dirty_time)) - wb_wakeup(&bdi->wb); + if (!list_empty(&wb->b_dirty_time)) + wb_wakeup(wb); } rcu_read_unlock(); schedule_delayed_work(&dirtytime_work, dirtytime_expire_interval * HZ); |