diff options
| author | Wei Yang <richardw.yang@linux.intel.com> | 2019-11-30 17:50:37 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2019-12-01 06:29:18 -0800 |
| commit | 408a60eddd206134fd306dfbc53bbde093b8deb0 (patch) | |
| tree | 9eada5a1b30300eda5723a7dc7a40e246bee4f36 | |
| parent | e4dcad204d3a281be6f8573e0a82648a4ad84e69 (diff) | |
| download | lwn-408a60eddd206134fd306dfbc53bbde093b8deb0.tar.gz lwn-408a60eddd206134fd306dfbc53bbde093b8deb0.zip | |
mm/mmap.c: remove a never-triggered warning in __vma_adjust()
The upper level of "if" makes sure (end >= next->vm_end), which means
there are only two possibilities:
1) end == next->vm_end
2) end > next->vm_end
remove_next is assigned to be (1 + end > next->vm_end). This means if
remove_next is 1, end must equal to next->vm_end.
The VM_WARN_ON will never trigger.
Link: http://lkml.kernel.org/r/20190912063126.13250-1-richardw.yang@linux.intel.com
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Yang Shi <yang.shi@linux.alibaba.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | mm/mmap.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/mm/mmap.c b/mm/mmap.c index a7d8c84d19b7..e27bc5dcd6c4 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -769,8 +769,6 @@ int __vma_adjust(struct vm_area_struct *vma, unsigned long start, remove_next = 1 + (end > next->vm_end); VM_WARN_ON(remove_next == 2 && end != next->vm_next->vm_end); - VM_WARN_ON(remove_next == 1 && - end != next->vm_end); /* trim end to next, for case 6 first pass */ end = next->vm_end; } |