diff options
| author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2023-05-06 18:06:43 -0300 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2023-05-06 18:06:43 -0300 |
| commit | c3e6df97fa25ff310c3d5e7f1644248e072e3cb0 (patch) | |
| tree | 8874570f276a37d2808b91e8d11413729832d535 | |
| parent | 6c73f819b6b6d6f052e8dbe3f66f0693554ddf48 (diff) | |
| download | lwn-c3e6df97fa25ff310c3d5e7f1644248e072e3cb0.tar.gz lwn-c3e6df97fa25ff310c3d5e7f1644248e072e3cb0.zip | |
Revert "perf build: Warn for BPF skeletons if endian mismatches"
This reverts commit 51924ae69eea5bc90b5da525fbcf4bbd5f8551b3.
We need to better polish building with BPF skels, so revert back to
making it an experimental feature that has to be explicitely enabled
using BUILD_BPF_SKEL=1.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
| -rw-r--r-- | tools/perf/Makefile.config | 17 |
1 files changed, 7 insertions, 10 deletions
diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index 71442c54c25f..16bea51f0bcd 100644 --- a/tools/perf/Makefile.config +++ b/tools/perf/Makefile.config @@ -663,17 +663,14 @@ ifndef NO_BPF_SKEL $(call feature_check,clang-bpf-co-re) ifeq ($(feature-clang-bpf-co-re), 0) dummy := $(error: ERROR: BPF skeletons unsupported. clang too old/not installed or build with NO_BPF_SKEL=1.) + else + ifeq ($(filter -DHAVE_LIBBPF_SUPPORT, $(CFLAGS)),) + dummy := $(error: ERROR: BPF skeletons unsupported. BPF skeleton support requires libbpf or build with NO_BPF_SKEL=1.) + else + $(call detected,CONFIG_PERF_BPF_SKEL) + CFLAGS += -DHAVE_BPF_SKEL + endif endif - ifeq ($(filter -DHAVE_LIBBPF_SUPPORT, $(CFLAGS)),) - dummy := $(error: ERROR: BPF skeletons unsupported. BPF skeleton support requires libbpf or build with NO_BPF_SKEL=1.) - endif - host_byte_order=$(echo ""|$(HOSTCC) -dM -E -|grep __BYTE_ORDER__) - target_byte_order=$(echo ""|$(CC) -dM -E -|grep __BYTE_ORDER__) - ifneq ($(host_byte_order), $(target_byte_order)) - $(warning Possibly mismatched host and target endianness may break BPF skeletons) - endif - $(call detected,CONFIG_PERF_BPF_SKEL) - CFLAGS += -DHAVE_BPF_SKEL endif dwarf-post-unwind := 1 |