diff options
| author | Jens Axboe <axboe@kernel.dk> | 2022-03-25 16:39:57 -0600 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2022-04-24 17:34:19 -0600 |
| commit | b4f20bb4e6d55a971d5f5555a971978a6263d8de (patch) | |
| tree | 3905d2c906de038153132a211330dd2dbc3dc011 | |
| parent | 775a1f2f99483bda4e43376ebbc6b459c8fbf20a (diff) | |
| download | lwn-b4f20bb4e6d55a971d5f5555a971978a6263d8de.tar.gz lwn-b4f20bb4e6d55a971d5f5555a971978a6263d8de.zip | |
io_uring: move finish_wait() outside of loop in cqring_wait()
We don't need to call this for every loop. This is particularly
troublesome if we are task_work intensive, and get woken more often than
we desire due to that.
Just do it at the end, that's always safe as we initialize the waitqueue
list head anyway. This can save a considerable amount of hammering on
the waitqueue lock, which is also hot from the request completion side.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | fs/io_uring.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/io_uring.c b/fs/io_uring.c index 007dc1c14af4..ed3f26259122 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -8174,10 +8174,10 @@ static int io_cqring_wait(struct io_ring_ctx *ctx, int min_events, prepare_to_wait_exclusive(&ctx->cq_wait, &iowq.wq, TASK_INTERRUPTIBLE); ret = io_cqring_wait_schedule(ctx, &iowq, timeout); - finish_wait(&ctx->cq_wait, &iowq.wq); cond_resched(); } while (ret > 0); + finish_wait(&ctx->cq_wait, &iowq.wq); restore_saved_sigmask_unless(ret == -EINTR); return READ_ONCE(rings->cq.head) == READ_ONCE(rings->cq.tail) ? ret : 0; |