diff options
| author | Qiushi Wu <wu000273@umn.edu> | 2020-05-22 14:07:15 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-05-23 16:34:37 -0700 |
| commit | febfd9d3c7f74063e8e630b15413ca91b567f963 (patch) | |
| tree | f639112705778933bb6d0bd07f204ab33e16b03d | |
| parent | 4c64b83d03f4aafcdf710caad994cbc855802e74 (diff) | |
| download | lwn-febfd9d3c7f74063e8e630b15413ca91b567f963.tar.gz lwn-febfd9d3c7f74063e8e630b15413ca91b567f963.zip | |
net/mlx4_core: fix a memory leak bug.
In function mlx4_opreq_action(), pointer "mailbox" is not released,
when mlx4_cmd_box() return and error, causing a memory leak bug.
Fix this issue by going to "out" label, mlx4_free_cmd_mailbox() can
free this pointer.
Fixes: fe6f700d6cbb ("net/mlx4_core: Respond to operation request by firmware")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/fw.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c index 6e501af0e532..f6ff9620a137 100644 --- a/drivers/net/ethernet/mellanox/mlx4/fw.c +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c @@ -2734,7 +2734,7 @@ void mlx4_opreq_action(struct work_struct *work) if (err) { mlx4_err(dev, "Failed to retrieve required operation: %d\n", err); - return; + goto out; } MLX4_GET(modifier, outbox, GET_OP_REQ_MODIFIER_OFFSET); MLX4_GET(token, outbox, GET_OP_REQ_TOKEN_OFFSET); |