diff options
author | Zenghui Yu <yuzenghui@huawei.com> | 2020-04-08 19:43:52 +0800 |
---|---|---|
committer | Marc Zyngier <maz@kernel.org> | 2020-04-17 08:59:27 +0100 |
commit | edfc23f6f9fdbd7825d50ac1f380243cde19b679 (patch) | |
tree | 931c7529c8d3a05417f757109479016cf661b749 | |
parent | 8f3d9f354286745c751374f5f1fcafee6b3f3136 (diff) | |
download | lwn-edfc23f6f9fdbd7825d50ac1f380243cde19b679.tar.gz lwn-edfc23f6f9fdbd7825d50ac1f380243cde19b679.zip |
irqchip/mbigen: Free msi_desc on device teardown
Using irq_domain_free_irqs_common() on the irqdomain free path will
leave the MSI descriptor unfreed when platform devices get removed.
Properly free it by MSI domain free function.
Fixes: 9650c60ebfec0 ("irqchip/mbigen: Create irq domain for each mbigen device")
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20200408114352.1604-1-yuzenghui@huawei.com
-rw-r--r-- | drivers/irqchip/irq-mbigen.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c index 6b566bba263b..ff7627b57772 100644 --- a/drivers/irqchip/irq-mbigen.c +++ b/drivers/irqchip/irq-mbigen.c @@ -220,10 +220,16 @@ static int mbigen_irq_domain_alloc(struct irq_domain *domain, return 0; } +static void mbigen_irq_domain_free(struct irq_domain *domain, unsigned int virq, + unsigned int nr_irqs) +{ + platform_msi_domain_free(domain, virq, nr_irqs); +} + static const struct irq_domain_ops mbigen_domain_ops = { .translate = mbigen_domain_translate, .alloc = mbigen_irq_domain_alloc, - .free = irq_domain_free_irqs_common, + .free = mbigen_irq_domain_free, }; static int mbigen_of_create_domain(struct platform_device *pdev, |