diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2019-11-07 10:48:47 +0300 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2019-11-08 06:55:22 -0700 |
| commit | 8e9c523016cf9983b295e4bc659183d1fa6ef8e0 (patch) | |
| tree | b8c8d9ae92beeb320dcf4985ea5909815b423839 | |
| parent | b0814361a25cba73a224548843ed92d8ea78715a (diff) | |
| download | lwn-8e9c523016cf9983b295e4bc659183d1fa6ef8e0.tar.gz lwn-8e9c523016cf9983b295e4bc659183d1fa6ef8e0.zip | |
block: drbd: remove a stray unlock in __drbd_send_protocol()
There are two callers of this function and they both unlock the mutex so
this ends up being a double unlock.
Fixes: 44ed167da748 ("drbd: rcu_read_lock() and rcu_dereference() for tconn->net_conf")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | drivers/block/drbd/drbd_main.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c index 5b248763a672..a18155cdce41 100644 --- a/drivers/block/drbd/drbd_main.c +++ b/drivers/block/drbd/drbd_main.c @@ -786,7 +786,6 @@ int __drbd_send_protocol(struct drbd_connection *connection, enum drbd_packet cm if (nc->tentative && connection->agreed_pro_version < 92) { rcu_read_unlock(); - mutex_unlock(&sock->mutex); drbd_err(connection, "--dry-run is not supported by peer"); return -EOPNOTSUPP; } |