diff options
| author | Mike Christie <mchristi@redhat.com> | 2017-05-31 15:52:40 -0500 |
|---|---|---|
| committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2017-07-06 23:11:46 -0700 |
| commit | 406f74c20dc258f8258b64d16d159c3fff06a506 (patch) | |
| tree | 12613727fab75dbed4182e0a8e68262de0f2be28 | |
| parent | c6d66aba98a39cfed206c5c61f0a604ba09b26ce (diff) | |
| download | lwn-406f74c20dc258f8258b64d16d159c3fff06a506.tar.gz lwn-406f74c20dc258f8258b64d16d159c3fff06a506.zip | |
tcmu: fix sense handling during completion
We were just copying the sense to the cmd sense_buffer and
did not implement a transport_complete or set the
SCF_TRANSPORT_TASK_SENSE, so the sense was ignored.
Signed-off-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
| -rw-r--r-- | drivers/target/target_core_user.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c index a8ff6b5fdec8..cbbfba0c1352 100644 --- a/drivers/target/target_core_user.c +++ b/drivers/target/target_core_user.c @@ -956,8 +956,7 @@ static void tcmu_handle_completion(struct tcmu_cmd *cmd, struct tcmu_cmd_entry * cmd->se_cmd); entry->rsp.scsi_status = SAM_STAT_CHECK_CONDITION; } else if (entry->rsp.scsi_status == SAM_STAT_CHECK_CONDITION) { - memcpy(se_cmd->sense_buffer, entry->rsp.sense_buffer, - se_cmd->scsi_sense_length); + transport_copy_sense_to_cmd(se_cmd, entry->rsp.sense_buffer); } else if (se_cmd->se_cmd_flags & SCF_BIDI) { /* Get Data-In buffer before clean up */ gather_data_area(udev, cmd, true); |