diff options
| author | zhong jiang <zhongjiang@huawei.com> | 2018-09-20 17:37:45 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-09-21 09:04:37 -0700 |
| commit | 673eed0c18341383ee0b5131935185f6f2bd6278 (patch) | |
| tree | f62d00acd596ca380e609c7f9ef8340635051838 | |
| parent | e3c3215e41f60f9debb17f920e4da7cb3a82a55b (diff) | |
| download | lwn-673eed0c18341383ee0b5131935185f6f2bd6278.tar.gz lwn-673eed0c18341383ee0b5131935185f6f2bd6278.zip | |
net: cxgb3_main: remove redundant null pointer check before kfree_skb
kfree_skb has taken the null pointer into account. hence it is safe
to remove the redundant null pointer check before kfree_skb.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c index 921dd71f9cda..8b0a253a18d8 100644 --- a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c +++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c @@ -3422,8 +3422,7 @@ static void remove_one(struct pci_dev *pdev) free_netdev(adapter->port[i]); iounmap(adapter->regs); - if (adapter->nofail_skb) - kfree_skb(adapter->nofail_skb); + kfree_skb(adapter->nofail_skb); kfree(adapter); pci_release_regions(pdev); pci_disable_device(pdev); |