diff options
| author | Yuval Mintz <Yuval.Mintz@qlogic.com> | 2015-08-10 12:49:35 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-08-10 14:31:58 -0700 |
| commit | e1615903eb6b5e599396d4b3d8e3e96f6d432a6e (patch) | |
| tree | ffa80a87ce4074718727cfb410c81fc16eefe6a2 | |
| parent | 21a447637d28eb824a1163c1fc5f41ffa4b28e33 (diff) | |
| download | lwn-e1615903eb6b5e599396d4b3d8e3e96f6d432a6e.tar.gz lwn-e1615903eb6b5e599396d4b3d8e3e96f6d432a6e.zip | |
bnx2x: Prevent null pointer dereference on SKB release
On error flows its possible to free an SKB even if it was not allocated.
Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: Ariel Elior <Ariel.Elior@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c index a90d7364334f..f7fbdc9d1325 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c @@ -262,9 +262,9 @@ static u16 bnx2x_free_tx_pkt(struct bnx2x *bp, struct bnx2x_fp_txdata *txdata, if (likely(skb)) { (*pkts_compl)++; (*bytes_compl) += skb->len; + dev_kfree_skb_any(skb); } - dev_kfree_skb_any(skb); tx_buf->first_bd = 0; tx_buf->skb = NULL; |