diff options
| author | Nicolas Iooss <nicolas.iooss_linux@m4x.org> | 2017-05-20 13:27:00 +0200 |
|---|---|---|
| committer | Masahiro Yamada <yamada.masahiro@socionext.com> | 2017-06-06 01:22:48 +0900 |
| commit | 3def03441e53e29eed3afd9009974a5a42bf124a (patch) | |
| tree | f453118f5f607c8c6ba4efe8cf5a5f9b126c4247 | |
| parent | 08332893e37af6ae779367e78e444f8f9571511d (diff) | |
| download | lwn-3def03441e53e29eed3afd9009974a5a42bf124a.tar.gz lwn-3def03441e53e29eed3afd9009974a5a42bf124a.zip | |
genksyms: add printf format attribute to error_with_pos()
When compiling with -Wsuggest-attribute=format in HOSTCFLAGS, gcc
complains that error_with_pos() may be declared with a printf format
attribute:
scripts/genksyms/genksyms.c:726:3: warning: function might be
possible candidate for ‘gnu_printf’ format attribute
[-Wsuggest-attribute=format]
vfprintf(stderr, fmt, args);
^~~~~~~~
This would allow catching printf-format errors at compile time in
callers to error_with_pos(). Add this attribute.
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
| -rw-r--r-- | scripts/genksyms/genksyms.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/genksyms/genksyms.h b/scripts/genksyms/genksyms.h index 3bffdcaaa274..b724a0290c75 100644 --- a/scripts/genksyms/genksyms.h +++ b/scripts/genksyms/genksyms.h @@ -75,7 +75,7 @@ struct string_list *copy_list_range(struct string_list *start, int yylex(void); int yyparse(void); -void error_with_pos(const char *, ...); +void error_with_pos(const char *, ...) __attribute__ ((format(printf, 1, 2))); /*----------------------------------------------------------------------*/ #define xmalloc(size) ({ void *__ptr = malloc(size); \ |