diff options
| author | Jaegeuk Kim <jaegeuk@kernel.org> | 2016-01-25 14:31:58 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-05-04 14:49:13 -0700 |
| commit | 73b5a1883361c3a0bd328ba8fa1348e09594229d (patch) | |
| tree | d7c824cd132ad154f6d098044e1aa26dbdaeb78a | |
| parent | cb3358c514b36f56f4dc52123f30c0e63a8af719 (diff) | |
| download | lwn-73b5a1883361c3a0bd328ba8fa1348e09594229d.tar.gz lwn-73b5a1883361c3a0bd328ba8fa1348e09594229d.zip | |
f2fs: don't need to call set_page_dirty for io error
commit e3ef18762f5757d3fb86f75ca59315db6d17d719 upstream.
If end_io gets an error, we don't need to set the page as dirty, since we
already set f2fs_stop_checkpoint which will not flush any data.
This will resolve the following warning.
======================================================
[ INFO: HARDIRQ-safe -> HARDIRQ-unsafe lock order detected ]
4.4.0+ #9 Tainted: G O
------------------------------------------------------
xfs_io/26773 [HC0[0]:SC0[0]:HE0:SE1] is trying to acquire:
(&(&sbi->inode_lock[i])->rlock){+.+...}, at: [<ffffffffc025483f>] update_dirty_page+0x6f/0xd0 [f2fs]
and this task is already holding:
(&(&q->__queue_lock)->rlock){-.-.-.}, at: [<ffffffff81396ea2>] blk_queue_bio+0x422/0x490
which would create a new lock dependency:
(&(&q->__queue_lock)->rlock){-.-.-.} -> (&(&sbi->inode_lock[i])->rlock){+.+...}
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/f2fs/data.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 3e2ea9a5e4d9..44802599fa67 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -67,7 +67,6 @@ static void f2fs_write_end_io(struct bio *bio) f2fs_restore_and_release_control_page(&page); if (unlikely(bio->bi_error)) { - set_page_dirty(page); set_bit(AS_EIO, &page->mapping->flags); f2fs_stop_checkpoint(sbi); } |