diff options
| author | Herbert Xu <herbert@gondor.apana.org.au> | 2016-01-19 21:23:57 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-02-17 12:31:04 -0800 |
| commit | 3dd3e2544c48d55e975efca5f34b77dbbe8895c9 (patch) | |
| tree | deff4eed93c3f5ab65091da63091b10e8bf79c80 | |
| parent | fec8beab63283003b546f83eebbbe32efb9acc53 (diff) | |
| download | lwn-3dd3e2544c48d55e975efca5f34b77dbbe8895c9.tar.gz lwn-3dd3e2544c48d55e975efca5f34b77dbbe8895c9.zip | |
crypto: algif_skcipher - sendmsg SG marking is off by one
commit 202736d99b7f29279db9da61587f11a08a04a9c6 upstream.
We mark the end of the SG list in sendmsg and sendpage and unmark
it on the next send call. Unfortunately the unmarking in sendmsg
is off-by-one, leading to an SG list that is too short.
Fixes: 0f477b655a52 ("crypto: algif - Mark sgl end at the end of data")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | crypto/algif_skcipher.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/crypto/algif_skcipher.c b/crypto/algif_skcipher.c index afb43392524f..76175e316e6b 100644 --- a/crypto/algif_skcipher.c +++ b/crypto/algif_skcipher.c @@ -392,7 +392,8 @@ static int skcipher_sendmsg(struct socket *sock, struct msghdr *msg, sgl = list_entry(ctx->tsgl.prev, struct skcipher_sg_list, list); sg = sgl->sg; - sg_unmark_end(sg + sgl->cur); + if (sgl->cur) + sg_unmark_end(sg + sgl->cur - 1); do { i = sgl->cur; plen = min_t(int, len, PAGE_SIZE); |