diff options
| author | Amitkumar Karwar <akarwar@marvell.com> | 2015-09-18 06:32:10 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-12-09 14:34:26 -0500 |
| commit | 0c7b4e0d36288a4695a56fd89dbf4c9e00ca9a0d (patch) | |
| tree | 77efe5ce29304da6bc43088b1979e01f5911f1e5 | |
| parent | a251acf26f718499da7db0aa8b73ee671c749028 (diff) | |
| download | lwn-0c7b4e0d36288a4695a56fd89dbf4c9e00ca9a0d.tar.gz lwn-0c7b4e0d36288a4695a56fd89dbf4c9e00ca9a0d.zip | |
mwifiex: avoid memsetting PCIe event buffer
commit 14d9c11c91a606fed65eaae2455423a23bb4ae59 upstream.
Preallocated PCIe buffer is being reused for all PCIe interface
events. Physical address of the buffer is shared with firmware
so that it can perform DMA on it. As event length is specified
in the header, there should not be a problem if the buffer gets
overwritten.
We will save some cycles by avoiding memset everytime while
submitting the buffer to firmware.
Fixes: 2728cecdc7d6bf3d21(mwifiex: corrections in PCIe event skb)
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/net/wireless/mwifiex/pcie.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/wireless/mwifiex/pcie.c b/drivers/net/wireless/mwifiex/pcie.c index 408b68460716..21192b6f9c64 100644 --- a/drivers/net/wireless/mwifiex/pcie.c +++ b/drivers/net/wireless/mwifiex/pcie.c @@ -1815,7 +1815,6 @@ static int mwifiex_pcie_event_complete(struct mwifiex_adapter *adapter, if (!card->evt_buf_list[rdptr]) { skb_push(skb, INTF_HEADER_LEN); skb_put(skb, MAX_EVENT_SIZE - skb->len); - memset(skb->data, 0, MAX_EVENT_SIZE); if (mwifiex_map_pci_memory(adapter, skb, MAX_EVENT_SIZE, PCI_DMA_FROMDEVICE)) |