diff options
| author | Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com> | 2015-08-11 07:57:23 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-08-12 14:37:33 -0700 |
| commit | b02e3e948de6c11fded1821d89012e24d953da12 (patch) | |
| tree | ba3c4bede51631f567f82ab97a6dd2bc8a930d92 | |
| parent | 211c504a444710b1d8ce3431ac19f2578602ca27 (diff) | |
| download | lwn-b02e3e948de6c11fded1821d89012e24d953da12.tar.gz lwn-b02e3e948de6c11fded1821d89012e24d953da12.zip | |
bonding: Gratuitous ARP gets dropped when first slave added
When the first slave is added (such as during bootup) the first
gratuitous ARP gets dropped. We don't see this drop during a failover.
The packet gets dropped in qdisc (noop_enqueue).
The fix is to delay the sending of gratuitous ARPs till the bond dev's
carrier is present.
It can also be worked around by setting num_grat_arp to more than 1.
Signed-off-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/bonding/bond_main.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index e1ccefce9a9d..a98dd4f1b0e3 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -786,6 +786,7 @@ static bool bond_should_notify_peers(struct bonding *bond) slave ? slave->dev->name : "NULL"); if (!slave || !bond->send_peer_notif || + !netif_carrier_ok(bond->dev) || test_bit(__LINK_STATE_LINKWATCH_PENDING, &slave->dev->state)) return false; |