diff options
| author | Jiri Kosina <jkosina@suse.cz> | 2015-04-09 13:32:35 +0200 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2015-04-10 17:32:21 +0200 |
| commit | 8fec02a73e31407e14986fca67dab48d4f777f0e (patch) | |
| tree | 8cae498d507f63e429c7e528f6332f6f998b3a47 | |
| parent | c627589282213bbef12a482c0b87f23526ceb3f0 (diff) | |
| download | lwn-8fec02a73e31407e14986fca67dab48d4f777f0e.tar.gz lwn-8fec02a73e31407e14986fca67dab48d4f777f0e.zip | |
HID: debug: fix error handling in hid_debug_events_read()
In the unlikely case of hdev vanishing while hid_debug_events_read() was
sleeping, we can't really break out of the case switch as with other cases,
as on the way out we'll try to remove ourselves from the hdev waitqueue.
Fix this by taking a shortcut exit path and avoiding cleanup that doesn't
make sense in case hdev doesn't exist any more anyway.
Reported-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
| -rw-r--r-- | drivers/hid/hid-debug.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c index 8bf61d295ffd..f5021fb3b674 100644 --- a/drivers/hid/hid-debug.c +++ b/drivers/hid/hid-debug.c @@ -1127,7 +1127,8 @@ static ssize_t hid_debug_events_read(struct file *file, char __user *buffer, if (!list->hdev || !list->hdev->debug) { ret = -EIO; - break; + set_current_state(TASK_RUNNING); + goto out; } /* allow O_NONBLOCK from other threads */ |