diff options
| author | Hyunchul Lee <cheol.lee@lge.com> | 2017-06-14 09:31:49 +0900 |
|---|---|---|
| committer | Richard Weinberger <richard@nod.at> | 2017-07-14 22:50:50 +0200 |
| commit | 480a1a6a3ef6fb6be4cd2f37b34314fbf64867dd (patch) | |
| tree | fba67215aa3a99176334885fd6774003bd11e43a | |
| parent | 07d41c3cf254a58b7ab69beb1f08a85ffce02626 (diff) | |
| download | lwn-480a1a6a3ef6fb6be4cd2f37b34314fbf64867dd.tar.gz lwn-480a1a6a3ef6fb6be4cd2f37b34314fbf64867dd.zip | |
ubifs: Change gfp flags in page allocation for bulk read
In low memory situations, page allocations for bulk read
can kill applications for reclaiming memory, and print an
failure message when allocations are failed.
Because bulk read is just an optimization, we don't have
to do these and can stop page allocations.
Though this siutation happens rarely, add __GFP_NORETRY
to prevent from excessive memory reclaim and killing
applications, and __GFP_WARN to suppress this failure
message.
For this, Use readahead_gfp_mask for gfp flags when
allocating pages.
Signed-off-by: Hyunchul Lee <cheol.lee@lge.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
| -rw-r--r-- | fs/ubifs/file.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c index c58efc1470f3..8cad0b19b404 100644 --- a/fs/ubifs/file.c +++ b/fs/ubifs/file.c @@ -735,6 +735,7 @@ static int ubifs_do_bulk_read(struct ubifs_info *c, struct bu_info *bu, int err, page_idx, page_cnt, ret = 0, n = 0; int allocate = bu->buf ? 0 : 1; loff_t isize; + gfp_t ra_gfp_mask = readahead_gfp_mask(mapping) & ~__GFP_FS; err = ubifs_tnc_get_bu_keys(c, bu); if (err) @@ -796,8 +797,7 @@ static int ubifs_do_bulk_read(struct ubifs_info *c, struct bu_info *bu, if (page_offset > end_index) break; - page = find_or_create_page(mapping, page_offset, - GFP_NOFS | __GFP_COLD); + page = find_or_create_page(mapping, page_offset, ra_gfp_mask); if (!page) break; if (!PageUptodate(page)) |