diff options
| author | Vivien Didelot <vivien.didelot@savoirfairelinux.com> | 2016-04-17 13:23:56 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-04-17 18:54:15 -0400 |
| commit | b346204737fafce585f62543ed7691fb4a72789d (patch) | |
| tree | 0502175681225bdb764240b7972b45d8515245a7 | |
| parent | 0209d144e3097fee1fe5d38532e6f0919c80d1ea (diff) | |
| download | lwn-b346204737fafce585f62543ed7691fb4a72789d.tar.gz lwn-b346204737fafce585f62543ed7691fb4a72789d.zip | |
net: dsa: mv88e6xxx: drop double ds assignment
Every driver assigns ps->ds even though it gets assigned in the shared
mv88e6xxx_setup_common function. Kill redundancy.
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/dsa/mv88e6123.c | 2 | ||||
| -rw-r--r-- | drivers/net/dsa/mv88e6131.c | 2 | ||||
| -rw-r--r-- | drivers/net/dsa/mv88e6171.c | 2 | ||||
| -rw-r--r-- | drivers/net/dsa/mv88e6352.c | 2 |
4 files changed, 0 insertions, 8 deletions
diff --git a/drivers/net/dsa/mv88e6123.c b/drivers/net/dsa/mv88e6123.c index 9701c0f9a60a..85537eb2806a 100644 --- a/drivers/net/dsa/mv88e6123.c +++ b/drivers/net/dsa/mv88e6123.c @@ -79,8 +79,6 @@ static int mv88e6123_setup(struct dsa_switch *ds) struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); int ret; - ps->ds = ds; - ret = mv88e6xxx_setup_common(ds); if (ret < 0) return ret; diff --git a/drivers/net/dsa/mv88e6131.c b/drivers/net/dsa/mv88e6131.c index fa3a35460453..4117c9b56571 100644 --- a/drivers/net/dsa/mv88e6131.c +++ b/drivers/net/dsa/mv88e6131.c @@ -101,8 +101,6 @@ static int mv88e6131_setup(struct dsa_switch *ds) struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); int ret; - ps->ds = ds; - ret = mv88e6xxx_setup_common(ds); if (ret < 0) return ret; diff --git a/drivers/net/dsa/mv88e6171.c b/drivers/net/dsa/mv88e6171.c index 8d86c9ee1adf..ae328750eae8 100644 --- a/drivers/net/dsa/mv88e6171.c +++ b/drivers/net/dsa/mv88e6171.c @@ -76,8 +76,6 @@ static int mv88e6171_setup(struct dsa_switch *ds) struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); int ret; - ps->ds = ds; - ret = mv88e6xxx_setup_common(ds); if (ret < 0) return ret; diff --git a/drivers/net/dsa/mv88e6352.c b/drivers/net/dsa/mv88e6352.c index c7fa69c9a564..10c36abf4c64 100644 --- a/drivers/net/dsa/mv88e6352.c +++ b/drivers/net/dsa/mv88e6352.c @@ -87,8 +87,6 @@ static int mv88e6352_setup(struct dsa_switch *ds) struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); int ret; - ps->ds = ds; - ret = mv88e6xxx_setup_common(ds); if (ret < 0) return ret; |