diff options
| author | Ilya Dryomov <idryomov@gmail.com> | 2015-06-24 17:24:33 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-08-03 09:29:18 -0700 |
| commit | a6a8032fb8622cf5ba914fbb5e8555f411d327d7 (patch) | |
| tree | 9852a388df2ed5967bcc2fbcab2b9c237b02b4e6 | |
| parent | 4932ba1eb094b3e7ef56ca9d11751543dce6c1e1 (diff) | |
| download | lwn-a6a8032fb8622cf5ba914fbb5e8555f411d327d7.tar.gz lwn-a6a8032fb8622cf5ba914fbb5e8555f411d327d7.zip | |
rbd: use GFP_NOIO in rbd_obj_request_create()
commit 5a60e87603c4c533492c515b7f62578189b03c9c upstream.
rbd_obj_request_create() is called on the main I/O path, so we need to
use GFP_NOIO to make sure allocation doesn't blow back on us. Not all
callers need this, but I'm still hardcoding the flag inside rather than
making it a parameter because a) this is going to stable, and b) those
callers shouldn't really use rbd_obj_request_create() and will be fixed
in the future.
More memory allocation fixes will follow.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/block/rbd.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index ec6c5c6e1ac9..53f253574abe 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -2001,11 +2001,11 @@ static struct rbd_obj_request *rbd_obj_request_create(const char *object_name, rbd_assert(obj_request_type_valid(type)); size = strlen(object_name) + 1; - name = kmalloc(size, GFP_KERNEL); + name = kmalloc(size, GFP_NOIO); if (!name) return NULL; - obj_request = kmem_cache_zalloc(rbd_obj_request_cache, GFP_KERNEL); + obj_request = kmem_cache_zalloc(rbd_obj_request_cache, GFP_NOIO); if (!obj_request) { kfree(name); return NULL; |