diff options
| author | Trond Myklebust <trond.myklebust@primarydata.com> | 2016-09-11 14:50:01 -0400 |
|---|---|---|
| committer | Sasha Levin <alexander.levin@verizon.com> | 2016-10-02 20:44:44 -0400 |
| commit | f40afeebc9bd778d91b3a8f90630538e2fed6bef (patch) | |
| tree | d46a6eec1306d21a8856df1ea0763ee1f83fcbb9 | |
| parent | 41beb77f7e59e17d675f159ae83c34b6545b7316 (diff) | |
| download | lwn-f40afeebc9bd778d91b3a8f90630538e2fed6bef.tar.gz lwn-f40afeebc9bd778d91b3a8f90630538e2fed6bef.zip | |
NFSv4.1: Fix the CREATE_SESSION slot number accounting
[ Upstream commit b519d408ea32040b1c7e10b155a3ee9a36660947 ]
Ensure that we conform to the algorithm described in RFC5661, section
18.36.4 for when to bump the sequence id. In essence we do it for all
cases except when the RPC call timed out, or in case of the server returning
NFS4ERR_DELAY or NFS4ERR_STALE_CLIENTID.
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: stable@vger.kernel.org
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
| -rw-r--r-- | fs/nfs/nfs4proc.c | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index eef16ec0638a..319ba6814899 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -7281,12 +7281,20 @@ static int _nfs4_proc_create_session(struct nfs_client *clp, status = rpc_call_sync(session->clp->cl_rpcclient, &msg, RPC_TASK_TIMEOUT); trace_nfs4_create_session(clp, status); + switch (status) { + case -NFS4ERR_STALE_CLIENTID: + case -NFS4ERR_DELAY: + case -ETIMEDOUT: + case -EACCES: + case -EAGAIN: + goto out; + }; + + clp->cl_seqid++; if (!status) { /* Verify the session's negotiated channel_attrs values */ status = nfs4_verify_channel_attrs(&args, &res); /* Increment the clientid slot sequence id */ - if (clp->cl_seqid == res.seqid) - clp->cl_seqid++; if (status) goto out; nfs4_update_session(session, &res); |