diff options
| author | Li Jun <jun.li@nxp.com> | 2016-08-16 19:19:11 +0800 |
|---|---|---|
| committer | Sasha Levin <alexander.levin@verizon.com> | 2016-09-12 09:33:21 -0400 |
| commit | b1918a087335a8ed6c8f1f090e3a41a62f8a3818 (patch) | |
| tree | b83926a88caada20327ecd5df8c534678533fa16 | |
| parent | 1898b62966e8c8d979278c66a977ba0fc3a2d128 (diff) | |
| download | lwn-b1918a087335a8ed6c8f1f090e3a41a62f8a3818.tar.gz lwn-b1918a087335a8ed6c8f1f090e3a41a62f8a3818.zip | |
usb: chipidea: udc: don't touch DP when controller is in host mode
[ Upstream commit c4e94174983a86c935be1537a73e496b778b0287 ]
When the controller is configured to be dual role and it's in host mode,
if bind udc and gadgt driver, those gadget operations will do gadget
disconnect and finally pull down DP line, which will break host function.
Cc: <stable@vger.kernel.org> # 4.1+
Signed-off-by: Li Jun <jun.li@nxp.com>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
| -rw-r--r-- | drivers/usb/chipidea/udc.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 92937c14f818..d93e43cfb6f8 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c @@ -1578,8 +1578,11 @@ static int ci_udc_pullup(struct usb_gadget *_gadget, int is_on) { struct ci_hdrc *ci = container_of(_gadget, struct ci_hdrc, gadget); - /* Data+ pullup controlled by OTG state machine in OTG fsm mode */ - if (ci_otg_is_fsm_mode(ci)) + /* + * Data+ pullup controlled by OTG state machine in OTG fsm mode; + * and don't touch Data+ in host mode for dual role config. + */ + if (ci_otg_is_fsm_mode(ci) || ci->role == CI_ROLE_HOST) return 0; pm_runtime_get_sync(&ci->gadget.dev); |