diff options
| author | Jouni Malinen <jouni@qca.qualcomm.com> | 2016-03-01 00:29:00 +0200 |
|---|---|---|
| committer | Sasha Levin <sasha.levin@oracle.com> | 2016-03-22 11:10:26 -0400 |
| commit | 7ce08a0c9992da8986b06154a768646e41012469 (patch) | |
| tree | 15159fbf3f4a37d140ff9c8059438d716882e031 | |
| parent | 87e0016ccb1f9cbe377d4af19cb840acbbdff206 (diff) | |
| download | lwn-7ce08a0c9992da8986b06154a768646e41012469.tar.gz lwn-7ce08a0c9992da8986b06154a768646e41012469.zip | |
mac80211: Fix Public Action frame RX in AP mode
[ Upstream commit 1ec7bae8bec9b72e347e01330c745ab5cdd66f0e ]
Public Action frames use special rules for how the BSSID field (Address
3) is set. A wildcard BSSID is used in cases where the transmitter and
recipient are not members of the same BSS. As such, we need to accept
Public Action frames with wildcard BSSID.
Commit db8e17324553 ("mac80211: ignore frames between TDLS peers when
operating as AP") added a rule that drops Action frames to TDLS-peers
based on an Action frame having different DA (Address 1) and BSSID
(Address 3) values. This is not correct since it misses the possibility
of BSSID being a wildcard BSSID in which case the Address 1 would not
necessarily match.
Fix this by allowing mac80211 to accept wildcard BSSID in an Action
frame when in AP mode.
Fixes: db8e17324553 ("mac80211: ignore frames between TDLS peers when operating as AP")
Cc: stable@vger.kernel.org
Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
| -rw-r--r-- | net/mac80211/rx.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c index 3244a0074d60..d4b08d87537c 100644 --- a/net/mac80211/rx.c +++ b/net/mac80211/rx.c @@ -3377,6 +3377,7 @@ static bool prepare_for_handlers(struct ieee80211_rx_data *rx, return false; /* ignore action frames to TDLS-peers */ if (ieee80211_is_action(hdr->frame_control) && + !is_broadcast_ether_addr(bssid) && !ether_addr_equal(bssid, hdr->addr1)) return false; } |