diff options
| author | Jate Sujjavanich <jsujjavanich@syntech-fuelmaster.com> | 2010-09-29 09:44:32 -0400 |
|---|---|---|
| committer | Grant Likely <grant.likely@secretlab.ca> | 2010-12-29 23:28:25 -0700 |
| commit | 0bc463426ab5eb39e76df637b29a4f191d01b8a0 (patch) | |
| tree | 815c32b4cccf81c55709da28d424782e81b19efe | |
| parent | 42ce7fd6319bed8ecb26d656c476365da46b29e9 (diff) | |
| download | lwn-0bc463426ab5eb39e76df637b29a4f191d01b8a0.tar.gz lwn-0bc463426ab5eb39e76df637b29a4f191d01b8a0.zip | |
spi/m68knommu: Coldfire QSPI platform support
After grabbing a msg from the msgq, the mcfqspi_work function calls
list_del_init on the mcfqspi->msgq which unintentionally deletes the rest
of the list before it can be processed. If qspi call was made using
spi_sync, this can result in a process hang.
Signed-off-by: Jate Sujjavanich <jsujjavanich@syntech-fuelmaster.com>
Acked-by: Steven King <sfking@fdwdc.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
| -rw-r--r-- | drivers/spi/coldfire_qspi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/coldfire_qspi.c b/drivers/spi/coldfire_qspi.c index 052b3c7fa6a0..8856bcca9d29 100644 --- a/drivers/spi/coldfire_qspi.c +++ b/drivers/spi/coldfire_qspi.c @@ -317,7 +317,7 @@ static void mcfqspi_work(struct work_struct *work) msg = container_of(mcfqspi->msgq.next, struct spi_message, queue); - list_del_init(&mcfqspi->msgq); + list_del_init(&msg->queue); spin_unlock_irqrestore(&mcfqspi->lock, flags); spi = msg->spi; |