diff options
| author | Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> | 2013-04-17 15:58:28 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-04-25 12:51:09 -0700 |
| commit | eb586a6aac367fe5589ae115d470c2c2de45f6fb (patch) | |
| tree | cfeb084fc243de2b256fbdacab3b72a07c365228 | |
| parent | bff55c65c423aad2d509e01e6703f098620b3c58 (diff) | |
| download | lwn-eb586a6aac367fe5589ae115d470c2c2de45f6fb.tar.gz lwn-eb586a6aac367fe5589ae115d470c2c2de45f6fb.zip | |
fs/binfmt_elf.c: fix hugetlb memory check in vma_dump_size()
commit 23d9e482136e31c9d287633a6e473daa172767c4 upstream.
Documentation/filesystems/proc.txt says about coredump_filter bitmask,
Note bit 0-4 doesn't effect any hugetlb memory. hugetlb memory are only
effected by bit 5-6.
However current code can go into the subsequent flag checks of bit 0-4
for vma(VM_HUGETLB). So this patch inserts 'return' and makes it work
as written in the document.
Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
Acked-by: Michal Hocko <mhocko@suse.cz>
Reviewed-by: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | fs/binfmt_elf.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 0c42cdbabecf..5843a4740f64 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -1132,6 +1132,7 @@ static unsigned long vma_dump_size(struct vm_area_struct *vma, goto whole; if (!(vma->vm_flags & VM_SHARED) && FILTER(HUGETLB_PRIVATE)) goto whole; + return 0; } /* Do not dump I/O mapped devices or special mappings */ |