diff options
| author | Tao Ma <boyu.mt@taobao.com> | 2012-09-20 11:35:38 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-12-03 11:38:15 -0800 |
| commit | 5770e9ed8a5b8ae7204e6cfe52565f10395091e4 (patch) | |
| tree | 4d586674e5732c554b2f123a6861cb2666fd114a | |
| parent | 5433889db1b04159054a9e6357f90c77970cf4ed (diff) | |
| download | lwn-5770e9ed8a5b8ae7204e6cfe52565f10395091e4.tar.gz lwn-5770e9ed8a5b8ae7204e6cfe52565f10395091e4.zip | |
ext4: remove erroneous ext4_superblock_csum_set() in update_backups()
commit bef53b01faeb791e27605cba1a71ba21364cb23e upstream.
The update_backups() function is used to backup all the metadata
blocks, so we should not take it for granted that 'data' is pointed to
a super block and use ext4_superblock_csum_set to calculate the
checksum there. In case where the data is a group descriptor block,
it will corrupt the last group descriptor, and then e2fsck will
complain about it it.
As all the metadata checksums should already be OK when we do the
backup, remove the wrong ext4_superblock_csum_set and it should be
just fine.
Reported-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/ext4/resize.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index 101b41c6844c..82e1fde3e0ef 100644 --- a/fs/ext4/resize.c +++ b/fs/ext4/resize.c @@ -979,8 +979,6 @@ static void update_backups(struct super_block *sb, goto exit_err; } - ext4_superblock_csum_set(sb); - while ((group = ext4_list_backups(sb, &three, &five, &seven)) < last) { struct buffer_head *bh; |