diff options
| author | Salva Peiró <speiro@ai2.upv.es> | 2013-12-17 10:06:30 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-01-15 15:27:11 -0800 |
| commit | eb2da112485dc59834cf1a87036b3a7a43fba3c4 (patch) | |
| tree | 2589b78c059e13d037680de270f470ca402cf665 | |
| parent | b7e3762c40e1d7f7a147f7d5be9584e1603bea01 (diff) | |
| download | lwn-eb2da112485dc59834cf1a87036b3a7a43fba3c4.tar.gz lwn-eb2da112485dc59834cf1a87036b3a7a43fba3c4.zip | |
hamradio/yam: fix info leak in ioctl
[ Upstream commit 8e3fbf870481eb53b2d3a322d1fc395ad8b367ed ]
The yam_ioctl() code fails to initialise the cmd field
of the struct yamdrv_ioctl_cfg. Add an explicit memset(0)
before filling the structure to avoid the 4-byte info leak.
Signed-off-by: Salva Peiró <speiro@ai2.upv.es>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/net/hamradio/yam.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c index 5a6412ecce73..d8faeb628aa7 100644 --- a/drivers/net/hamradio/yam.c +++ b/drivers/net/hamradio/yam.c @@ -1058,6 +1058,7 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) break; case SIOCYAMGCFG: + memset(&yi, 0, sizeof(yi)); yi.cfg.mask = 0xffffffff; yi.cfg.iobase = yp->iobase; yi.cfg.irq = yp->irq; |