diff options
| author | Jiri Kosina <jkosina@suse.cz> | 2014-08-27 09:13:15 +0200 |
|---|---|---|
| committer | Zefan Li <lizefan@huawei.com> | 2014-09-25 11:49:15 +0800 |
| commit | e78c127e8ee714142edb1d76956ebf40750ab218 (patch) | |
| tree | 2dfdfd058a332c4ee71f8232d6ce7578b21e8578 | |
| parent | e115f02bda5dc98fc31cec1fe6160bcee887789c (diff) | |
| download | lwn-e78c127e8ee714142edb1d76956ebf40750ab218.tar.gz lwn-e78c127e8ee714142edb1d76956ebf40750ab218.zip | |
HID: picolcd: sanity check report size in raw_event() callback
commit 844817e47eef14141cf59b8d5ac08dd11c0a9189 upstream.
The report passed to us from transport driver could potentially be
arbitrarily large, therefore we better sanity-check it so that raw_data
that we hold in picolcd_pending structure are always kept within proper
bounds.
Reported-by: Steven Vittitoe <scvitti@google.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
[lizf: Backported to 3.4: adjust filename]
Signed-off-by: Zefan Li <lizefan@huawei.com>
| -rw-r--r-- | drivers/hid/hid-picolcd.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/hid/hid-picolcd.c b/drivers/hid/hid-picolcd.c index 95f90479f285..4e37b1f4c7e2 100644 --- a/drivers/hid/hid-picolcd.c +++ b/drivers/hid/hid-picolcd.c @@ -2370,6 +2370,12 @@ static int picolcd_raw_event(struct hid_device *hdev, if (!data) return 1; + if (size > 64) { + hid_warn(hdev, "invalid size value (%d) for picolcd raw event\n", + size); + return 0; + } + if (report->id == REPORT_KEY_STATE) { if (data->input_keys) ret = picolcd_raw_keypad(data, report, raw_data+1, size-1); |