diff options
| author | Axel Lin <axel.lin@gmail.com> | 2012-04-11 20:53:58 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-05-12 09:32:17 -0700 |
| commit | 89ec66f87f76f389887b04a415f6dd53305bb9d0 (patch) | |
| tree | 7073cf14ae498169e1c0e0ddfdbd64138e68d85a | |
| parent | c35fda8ad637d6f86fad00139f7faaf3d1133302 (diff) | |
| download | lwn-89ec66f87f76f389887b04a415f6dd53305bb9d0.tar.gz lwn-89ec66f87f76f389887b04a415f6dd53305bb9d0.zip | |
regulator: Fix the logic to ensure new voltage setting in valid range
commit f55205f4d4a8823a11bb8b37ef2ecbd78fb09463 upstream.
I think this is a typo.
To ensure new voltage setting won't greater than desc->max,
the equation should be desc->min + desc->step * new_val <= desc->max.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/regulator/max8997.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/regulator/max8997.c b/drivers/regulator/max8997.c index d26e8646277b..cf73ab2c17f2 100644 --- a/drivers/regulator/max8997.c +++ b/drivers/regulator/max8997.c @@ -689,7 +689,7 @@ static int max8997_set_voltage_buck(struct regulator_dev *rdev, } new_val++; - } while (desc->min + desc->step + new_val <= desc->max); + } while (desc->min + desc->step * new_val <= desc->max); new_idx = tmp_idx; new_val = tmp_val; |