diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2011-11-24 20:08:53 -0500 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2012-01-03 22:52:38 -0500 |
| commit | c5dc332eb93881fc8234d652f6e91a2825b06503 (patch) | |
| tree | 40327f76166c51e9109a6a1997566336529f6938 | |
| parent | aa0a4cf0ab4b03db21133a0ba62f558ed1bfcd1d (diff) | |
| download | lwn-c5dc332eb93881fc8234d652f6e91a2825b06503.tar.gz lwn-c5dc332eb93881fc8234d652f6e91a2825b06503.zip | |
tomoyo: stop including hell knows what
tomoyo/realpath.c needs exactly one include - that of common.h. It pulls
everything the thing needs, without doing ridiculous garbage such as trying
to include ../../fs/internal.h. If that alone doesn't scream "layering
violation", I don't know what does; and these days it's all for nothing,
since it fortunately does not use any symbols defined in there...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
| -rw-r--r-- | security/tomoyo/realpath.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/security/tomoyo/realpath.c b/security/tomoyo/realpath.c index d9f3ced8756e..2cb5db589c9d 100644 --- a/security/tomoyo/realpath.c +++ b/security/tomoyo/realpath.c @@ -4,15 +4,7 @@ * Copyright (C) 2005-2011 NTT DATA CORPORATION */ -#include <linux/types.h> -#include <linux/mount.h> -#include <linux/mnt_namespace.h> -#include <linux/fs_struct.h> -#include <linux/magic.h> -#include <linux/slab.h> -#include <net/sock.h> #include "common.h" -#include "../../fs/internal.h" /** * tomoyo_encode2 - Encode binary string to ascii string. |