diff options
| author | Ben Hutchings <ben@decadent.org.uk> | 2013-05-27 19:07:19 +0100 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2013-07-27 05:34:19 +0100 |
| commit | be45f4eba5d9c264dacd10dee0ba23ec14624911 (patch) | |
| tree | 99f134b9ba213e808ccc7b87aba451640af8486d | |
| parent | 6c23479357ed3a810e3b56b1076fc6d9a2fee6e8 (diff) | |
| download | lwn-be45f4eba5d9c264dacd10dee0ba23ec14624911.tar.gz lwn-be45f4eba5d9c264dacd10dee0ba23ec14624911.zip | |
sd: Fix parsing of 'temporary ' cache mode prefix
commit 2ee3e26c673e75c05ef8b914f54fadee3d7b9c88 upstream.
Commit 39c60a0948cc '[SCSI] sd: fix array cache flushing bug causing
performance problems' added temp as a pointer to "temporary " and used
sizeof(temp) - 1 as its length. But sizeof(temp) is the size of the
pointer, not the size of the string constant. Change temp to a static
array so that sizeof() does what was intended.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
| -rw-r--r-- | drivers/scsi/sd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 931cde031cff..6dace1a173db 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -138,7 +138,7 @@ sd_store_cache_type(struct device *dev, struct device_attribute *attr, char *buffer_data; struct scsi_mode_data data; struct scsi_sense_hdr sshdr; - const char *temp = "temporary "; + static const char temp[] = "temporary "; int len; if (sdp->type != TYPE_DISK) |