diff options
| author | Jan Kara <jack@suse.cz> | 2013-05-31 19:39:56 -0400 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2013-07-27 05:34:34 +0100 |
| commit | 967c9a98626b1e402ab042bd770b7109532f49fb (patch) | |
| tree | f3f8f870997f5722a48540e79c88ce149163ac2c | |
| parent | 6dfd19d0d4d5dd081e1312a550ffae6acc85d70a (diff) | |
| download | lwn-967c9a98626b1e402ab042bd770b7109532f49fb.tar.gz lwn-967c9a98626b1e402ab042bd770b7109532f49fb.zip | |
ext4: fix overflow when counting used blocks on 32-bit architectures
commit 8af8eecc1331dbf5e8c662022272cf667e213da5 upstream.
The arithmetics adding delalloc blocks to the number of used blocks in
ext4_getattr() can easily overflow on 32-bit archs as we first multiply
number of blocks by blocksize and then divide back by 512. Make the
arithmetics more clever and also use proper type (unsigned long long
instead of unsigned long).
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | fs/ext4/inode.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 025b4b6573d7..45778a62928c 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -4335,7 +4335,7 @@ int ext4_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat) { struct inode *inode; - unsigned long delalloc_blocks; + unsigned long long delalloc_blocks; inode = dentry->d_inode; generic_fillattr(inode, stat); @@ -4352,7 +4352,7 @@ int ext4_getattr(struct vfsmount *mnt, struct dentry *dentry, */ delalloc_blocks = EXT4_I(inode)->i_reserved_data_blocks; - stat->blocks += (delalloc_blocks << inode->i_sb->s_blocksize_bits)>>9; + stat->blocks += delalloc_blocks << (inode->i_sb->s_blocksize_bits-9); return 0; } |