diff options
author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2013-04-29 16:21:07 -0700 |
---|---|---|
committer | Ben Hutchings <ben@decadent.org.uk> | 2013-05-30 14:35:15 +0100 |
commit | 7abe9d39f7a6c39cb282dac10c9345e242b4c6fb (patch) | |
tree | ba0244a852220a0e4ae1bfa40f0e09c7a33f4ca4 | |
parent | 01b0d887f67a388fb2a658ee2bdd74e5ba146818 (diff) | |
download | lwn-7abe9d39f7a6c39cb282dac10c9345e242b4c6fb.tar.gz lwn-7abe9d39f7a6c39cb282dac10c9345e242b4c6fb.zip |
drivers/rtc/rtc-pcf2123.c: fix error return code in pcf2123_probe()
commit 35623715818dfa720cccf99cd280dcbb4b78da23 upstream.
Fix to return -ENODEV in the chip not found error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Cc: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
-rw-r--r-- | drivers/rtc/rtc-pcf2123.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c index 2ee3bbf7e5ea..62e1b2ca1d75 100644 --- a/drivers/rtc/rtc-pcf2123.c +++ b/drivers/rtc/rtc-pcf2123.c @@ -264,6 +264,7 @@ static int __devinit pcf2123_probe(struct spi_device *spi) if (!(rxbuf[0] & 0x20)) { dev_err(&spi->dev, "chip not found\n"); + ret = -ENODEV; goto kfree_exit; } |