diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2012-07-04 09:18:01 +0200 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2012-08-02 14:37:45 +0100 |
| commit | 6d0511498af83b9d09be2f52a69e3f9aca5db81e (patch) | |
| tree | ee489ab124968b563e9919d02cf839ff0179e27e | |
| parent | 87b98a1d1bd63f002763b5cb153928d260850234 (diff) | |
| download | lwn-6d0511498af83b9d09be2f52a69e3f9aca5db81e.tar.gz lwn-6d0511498af83b9d09be2f52a69e3f9aca5db81e.zip | |
usbdevfs: Correct amount of data copied to user in processcompl_compat
commit 2102e06a5f2e414694921f23591f072a5ba7db9f upstream.
iso data buffers may have holes in them if some packets were short, so for
iso urbs we should always copy the entire buffer, just like the regular
processcompl does.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | drivers/usb/core/devio.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index f6ff837e4bb5..a9df218e7337 100644 --- a/drivers/usb/core/devio.c +++ b/drivers/usb/core/devio.c @@ -1555,10 +1555,14 @@ static int processcompl_compat(struct async *as, void __user * __user *arg) void __user *addr = as->userurb; unsigned int i; - if (as->userbuffer && urb->actual_length) - if (copy_to_user(as->userbuffer, urb->transfer_buffer, - urb->actual_length)) + if (as->userbuffer && urb->actual_length) { + if (urb->number_of_packets > 0) /* Isochronous */ + i = urb->transfer_buffer_length; + else /* Non-Isoc */ + i = urb->actual_length; + if (copy_to_user(as->userbuffer, urb->transfer_buffer, i)) return -EFAULT; + } if (put_user(as->status, &userurb->status)) return -EFAULT; if (put_user(urb->actual_length, &userurb->actual_length)) |