diff options
| author | Jan Kara <jack@suse.cz> | 2012-06-27 20:20:22 +0200 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2012-07-12 04:32:10 +0100 |
| commit | 007871a045112d5e4228b69d9cf0fb95b73d3d71 (patch) | |
| tree | 5c28f91480bb18011519645df97ac6c0af6c0b96 | |
| parent | df2a300810d3e2b049ad363aa1081657a5eda8c6 (diff) | |
| download | lwn-007871a045112d5e4228b69d9cf0fb95b73d3d71.tar.gz lwn-007871a045112d5e4228b69d9cf0fb95b73d3d71.zip | |
udf: Avoid run away loop when partition table length is corrupted
commit adee11b2085bee90bd8f4f52123ffb07882d6256 upstream.
Check provided length of partition table so that (possibly maliciously)
corrupted partition table cannot cause accessing data beyond current buffer.
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | fs/udf/super.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/fs/udf/super.c b/fs/udf/super.c index eea2bfe0a8c7..800e83984099 100644 --- a/fs/udf/super.c +++ b/fs/udf/super.c @@ -1227,6 +1227,7 @@ static int udf_load_logicalvol(struct super_block *sb, sector_t block, struct genericPartitionMap *gpm; uint16_t ident; struct buffer_head *bh; + unsigned int table_len; int ret = 0; bh = udf_read_tagged(sb, block, block, &ident); @@ -1234,13 +1235,20 @@ static int udf_load_logicalvol(struct super_block *sb, sector_t block, return 1; BUG_ON(ident != TAG_IDENT_LVD); lvd = (struct logicalVolDesc *)bh->b_data; + table_len = le32_to_cpu(lvd->mapTableLength); + if (sizeof(*lvd) + table_len > sb->s_blocksize) { + udf_err(sb, "error loading logical volume descriptor: " + "Partition table too long (%u > %lu)\n", table_len, + sb->s_blocksize - sizeof(*lvd)); + goto out_bh; + } ret = udf_sb_alloc_partition_maps(sb, le32_to_cpu(lvd->numPartitionMaps)); if (ret) goto out_bh; for (i = 0, offset = 0; - i < sbi->s_partitions && offset < le32_to_cpu(lvd->mapTableLength); + i < sbi->s_partitions && offset < table_len; i++, offset += gpm->partitionMapLength) { struct udf_part_map *map = &sbi->s_partmaps[i]; gpm = (struct genericPartitionMap *) |