diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2010-08-15 18:51:56 +0200 |
|---|---|---|
| committer | Arnd Bergmann <arnd@arndb.de> | 2010-09-16 10:33:16 +0200 |
| commit | d9d2e9d5c9eead1f73f92f5fc03424dab90b6c95 (patch) | |
| tree | 9e315c7eabb32658d7b03ec3454fb075bfba9c4c | |
| parent | aadbd4360911d7166dc04c5a4e5520b2c7914c73 (diff) | |
| download | lwn-d9d2e9d5c9eead1f73f92f5fc03424dab90b6c95.tar.gz lwn-d9d2e9d5c9eead1f73f92f5fc03424dab90b6c95.zip | |
lirc: make chardev nonseekable
There does not seem to be a need for lirc to
allow seeking on the file descriptor, so let's
just disallow this before users start relying
on it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
| -rw-r--r-- | drivers/media/IR/ir-lirc-codec.c | 1 | ||||
| -rw-r--r-- | drivers/media/IR/lirc_dev.c | 2 | ||||
| -rw-r--r-- | drivers/staging/lirc/lirc_serial.c | 1 | ||||
| -rw-r--r-- | drivers/staging/lirc/lirc_sir.c | 1 |
4 files changed, 5 insertions, 0 deletions
diff --git a/drivers/media/IR/ir-lirc-codec.c b/drivers/media/IR/ir-lirc-codec.c index 77b5946413c0..8a128934e605 100644 --- a/drivers/media/IR/ir-lirc-codec.c +++ b/drivers/media/IR/ir-lirc-codec.c @@ -235,6 +235,7 @@ static struct file_operations lirc_fops = { .poll = lirc_dev_fop_poll, .open = lirc_dev_fop_open, .release = lirc_dev_fop_close, + .llseek = no_llseek, }; static int ir_lirc_register(struct input_dev *input_dev) diff --git a/drivers/media/IR/lirc_dev.c b/drivers/media/IR/lirc_dev.c index 899891bec352..5b145e8672fe 100644 --- a/drivers/media/IR/lirc_dev.c +++ b/drivers/media/IR/lirc_dev.c @@ -460,6 +460,8 @@ error: mutex_unlock(&lirc_dev_lock); + nonseekable_open(inode, file); + return retval; } EXPORT_SYMBOL(lirc_dev_fop_open); diff --git a/drivers/staging/lirc/lirc_serial.c b/drivers/staging/lirc/lirc_serial.c index 9456f8e3f9ef..8da382492612 100644 --- a/drivers/staging/lirc/lirc_serial.c +++ b/drivers/staging/lirc/lirc_serial.c @@ -1058,6 +1058,7 @@ static const struct file_operations lirc_fops = { .poll = lirc_dev_fop_poll, .open = lirc_dev_fop_open, .release = lirc_dev_fop_close, + .llseek = no_llseek, }; static struct lirc_driver driver = { diff --git a/drivers/staging/lirc/lirc_sir.c b/drivers/staging/lirc/lirc_sir.c index eb08fa7138ba..2478871bd95e 100644 --- a/drivers/staging/lirc/lirc_sir.c +++ b/drivers/staging/lirc/lirc_sir.c @@ -459,6 +459,7 @@ static const struct file_operations lirc_fops = { .unlocked_ioctl = lirc_ioctl, .open = lirc_dev_fop_open, .release = lirc_dev_fop_close, + .llseek = no_llseek, }; static int set_use_inc(void *data) |