summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIan Munsie <imunsie@au1.ibm.com>2015-02-04 19:10:38 +1100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-03-18 14:11:12 +0100
commit1181ed21a973f1a8c5a535276685cc09c43a246f (patch)
tree57e1b0d2f07a88767ba37948908c54f9d56f219f
parentd5bc28d181ddc8edf78e4203fae42755a24db94d (diff)
downloadlwn-1181ed21a973f1a8c5a535276685cc09c43a246f.tar.gz
lwn-1181ed21a973f1a8c5a535276685cc09c43a246f.zip
cxl: Add missing return statement after handling AFU errror
commit a6130ed253a931d2169c26ab0958d81b0dce4d6e upstream. We were missing a return statement in the PSL interrupt handler in the case of an AFU error, which would trigger an "Unhandled CXL PSL IRQ" warning. We do actually handle these type of errors (by notifying userspace), so add the missing return IRQ_HANDLED so we don't throw unecessary warnings. Signed-off-by: Ian Munsie <imunsie@au1.ibm.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/misc/cxl/irq.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/misc/cxl/irq.c b/drivers/misc/cxl/irq.c
index c294925f73ee..bfbe3c8ae7d6 100644
--- a/drivers/misc/cxl/irq.c
+++ b/drivers/misc/cxl/irq.c
@@ -167,6 +167,7 @@ static irqreturn_t cxl_irq(int irq, void *data, struct cxl_irq_info *irq_info)
}
cxl_ack_irq(ctx, CXL_PSL_TFC_An_A, 0);
+ return IRQ_HANDLED;
}
if (dsisr & CXL_PSL_DSISR_An_OC)
pr_devel("CXL interrupt: OS Context Warning\n");