diff options
| author | Michael Neuling <mikey@neuling.org> | 2016-04-22 14:57:48 +1000 |
|---|---|---|
| committer | Sasha Levin <sasha.levin@oracle.com> | 2016-05-17 14:32:43 -0400 |
| commit | 625e43ab5cdd182ea89b160e8ae7008f5bc0219c (patch) | |
| tree | f0721688221b1a4218bc8e195378b8e3720f70a5 | |
| parent | 8e1a3e4113a6e44f4dbe8e32bcdbe895529ea30a (diff) | |
| download | lwn-625e43ab5cdd182ea89b160e8ae7008f5bc0219c.tar.gz lwn-625e43ab5cdd182ea89b160e8ae7008f5bc0219c.zip | |
cxl: Keep IRQ mappings on context teardown
[ Upstream commit d6776bba44d9752f6cdf640046070e71ee4bba7b ]
Keep IRQ mappings on context teardown. This won't leak IRQs as if we
allocate the mapping again, the generic code will give the same
mapping used last time.
Doing this works around a race in the generic code. Masking the
interrupt introduces a race which can crash the kernel or result in
IRQ that is never EOIed. The lost of EOI results in all subsequent
mappings to the same HW IRQ never receiving an interrupt.
We've seen this race with cxl test cases which are doing heavy context
startup and teardown at the same time as heavy interrupt load.
A fix to the generic code is being investigated also.
Signed-off-by: Michael Neuling <mikey@neuling.org>
Cc: stable@vger.kernel.org # 3.8
Tested-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
Tested-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
| -rw-r--r-- | drivers/misc/cxl/irq.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/misc/cxl/irq.c b/drivers/misc/cxl/irq.c index 6fe4027feb7d..7355d9c114ef 100644 --- a/drivers/misc/cxl/irq.c +++ b/drivers/misc/cxl/irq.c @@ -272,7 +272,6 @@ unsigned int cxl_map_irq(struct cxl *adapter, irq_hw_number_t hwirq, void cxl_unmap_irq(unsigned int virq, void *cookie) { free_irq(virq, cookie); - irq_dispose_mapping(virq); } static int cxl_register_one_irq(struct cxl *adapter, |