diff options
| author | Benjamin Coddington <bcodding@redhat.com> | 2015-11-20 09:56:20 -0500 |
|---|---|---|
| committer | Sasha Levin <sasha.levin@oracle.com> | 2016-01-21 11:23:29 -0500 |
| commit | d48e82da8b064ed3ce8bfa2d8b17d8566e811f4f (patch) | |
| tree | 8692a216d7b6fa239569b10d2e677ad080b451a7 | |
| parent | e46b3f459f2efa11329013b3df96723ec4d2f314 (diff) | |
| download | lwn-d48e82da8b064ed3ce8bfa2d8b17d8566e811f4f.tar.gz lwn-d48e82da8b064ed3ce8bfa2d8b17d8566e811f4f.zip | |
nfs4: start callback_ident at idr 1
[ Upstream commit c68a027c05709330fe5b2f50c50d5fa02124b5d8 ]
If clp->cl_cb_ident is zero, then nfs_cb_idr_remove_locked() skips removing
it when the nfs_client is freed. A decoding or server bug can then find
and try to put that first nfs_client which would lead to a crash.
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Fixes: d6870312659d ("nfs4client: convert to idr_alloc()")
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
| -rw-r--r-- | fs/nfs/nfs4client.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfs/nfs4client.c b/fs/nfs/nfs4client.c index 368a6b72290c..0e11fe80e5b9 100644 --- a/fs/nfs/nfs4client.c +++ b/fs/nfs/nfs4client.c @@ -33,7 +33,7 @@ static int nfs_get_cb_ident_idr(struct nfs_client *clp, int minorversion) return ret; idr_preload(GFP_KERNEL); spin_lock(&nn->nfs_client_lock); - ret = idr_alloc(&nn->cb_ident_idr, clp, 0, 0, GFP_NOWAIT); + ret = idr_alloc(&nn->cb_ident_idr, clp, 1, 0, GFP_NOWAIT); if (ret >= 0) clp->cl_cb_ident = ret; spin_unlock(&nn->nfs_client_lock); |