diff options
| author | Hannes Frederic Sowa <hannes@stressinduktion.org> | 2015-12-15 21:01:53 +0100 |
|---|---|---|
| committer | Sasha Levin <sasha.levin@oracle.com> | 2016-01-15 18:41:52 -0500 |
| commit | 49d0edfda3a11d364b434d48ec92127d5f9ede38 (patch) | |
| tree | c62b387c34f631cbd092a165c5e1c6e9cca4d4e1 | |
| parent | 566198569555189eff9c11c67bbaefb1bacc7bfa (diff) | |
| download | lwn-49d0edfda3a11d364b434d48ec92127d5f9ede38.tar.gz lwn-49d0edfda3a11d364b434d48ec92127d5f9ede38.zip | |
fou: clean up socket with kfree_rcu
[ Upstream commit 3036facbb7be3a169e35be3b271162b0fa564a2d ]
fou->udp_offloads is managed by RCU. As it is actually included inside
the fou sockets, we cannot let the memory go out of scope before a grace
period. We either can synchronize_rcu or switch over to kfree_rcu to
manage the sockets. kfree_rcu seems appropriate as it is used by vxlan
and geneve.
Fixes: 23461551c00628c ("fou: Support for foo-over-udp RX path")
Cc: Tom Herbert <tom@herbertland.com>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
| -rw-r--r-- | net/ipv4/fou.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c index 606c520ffd5a..8ce8e82d1abb 100644 --- a/net/ipv4/fou.c +++ b/net/ipv4/fou.c @@ -25,6 +25,7 @@ struct fou { u16 port; struct udp_offload udp_offloads; struct list_head list; + struct rcu_head rcu; }; struct fou_cfg { @@ -287,7 +288,7 @@ static void fou_release(struct fou *fou) sock_release(sock); - kfree(fou); + kfree_rcu(fou, rcu); } static int fou_encap_init(struct sock *sk, struct fou *fou, struct fou_cfg *cfg) |