diff options
| author | Sudip Mukherjee <sudipm.mukherjee@gmail.com> | 2015-07-20 17:27:21 +0530 |
|---|---|---|
| committer | Sasha Levin <sasha.levin@oracle.com> | 2015-10-27 22:14:50 -0400 |
| commit | 825cc9616f9b826bb700973b58ae7affa3da5748 (patch) | |
| tree | 0ac2837f9f37e5a998e700dd8cb6b776070cde71 | |
| parent | 9f6e3432b9b0f30c83174ca3990b747675d9f768 (diff) | |
| download | lwn-825cc9616f9b826bb700973b58ae7affa3da5748.tar.gz lwn-825cc9616f9b826bb700973b58ae7affa3da5748.zip | |
auxdisplay: ks0108: fix refcount
[ Upstream commit bab383de3b84e584b0f09227151020b2a43dc34c ]
parport_find_base() will implicitly do parport_get_port() which
increases the refcount. Then parport_register_device() will again
increment the refcount. But while unloading the module we are only
doing parport_unregister_device() decrementing the refcount only once.
We add an parport_put_port() to neutralize the effect of
parport_get_port().
Cc: <stable@vger.kernel.org> # 2.6.32+
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
| -rw-r--r-- | drivers/auxdisplay/ks0108.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/auxdisplay/ks0108.c b/drivers/auxdisplay/ks0108.c index 5b93852392b8..0d752851a1ee 100644 --- a/drivers/auxdisplay/ks0108.c +++ b/drivers/auxdisplay/ks0108.c @@ -139,6 +139,7 @@ static int __init ks0108_init(void) ks0108_pardevice = parport_register_device(ks0108_parport, KS0108_NAME, NULL, NULL, NULL, PARPORT_DEV_EXCL, NULL); + parport_put_port(ks0108_parport); if (ks0108_pardevice == NULL) { printk(KERN_ERR KS0108_NAME ": ERROR: " "parport didn't register new device\n"); |