diff options
| author | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2010-07-09 10:21:21 +0200 |
|---|---|---|
| committer | Paul Mackerras <paulus@samba.org> | 2010-07-27 22:20:09 +1000 |
| commit | 6b95ed345b9faa4ab3598a82991968f2e9f851bb (patch) | |
| tree | 71dea1106bbe0b4cd0a7f8ba18b9a3d47e80c9bf | |
| parent | 1a041a23da7c77b53c71fe11b4f940388bee37b1 (diff) | |
| download | lwn-6b95ed345b9faa4ab3598a82991968f2e9f851bb.tar.gz lwn-6b95ed345b9faa4ab3598a82991968f2e9f851bb.zip | |
perf, powerpc: Use perf_sample_data_init() for the FSL code
We should use perf_sample_data_init() to initialize struct
perf_sample_data. As explained in the description of commit dc1d628a
("perf: Provide generic perf_sample_data initialization"), it is
possible for userspace to get the kernel to dereference data.raw,
so if it is not initialized, that means that unprivileged userspace
can possibly oops the kernel. Using perf_sample_data_init makes sure
it gets initialized to NULL.
This conversion should have been included in commit dc1d628a, but it
got missed.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Kumar Gala <kumar.gala@freescale.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
| -rw-r--r-- | arch/powerpc/kernel/perf_event_fsl_emb.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/arch/powerpc/kernel/perf_event_fsl_emb.c b/arch/powerpc/kernel/perf_event_fsl_emb.c index 369872f6cf78..babcceecd2ea 100644 --- a/arch/powerpc/kernel/perf_event_fsl_emb.c +++ b/arch/powerpc/kernel/perf_event_fsl_emb.c @@ -566,9 +566,9 @@ static void record_and_restart(struct perf_event *event, unsigned long val, * Finally record data if requested. */ if (record) { - struct perf_sample_data data = { - .period = event->hw.last_period, - }; + struct perf_sample_data data; + + perf_sample_data_init(&data, 0); if (perf_event_overflow(event, nmi, &data, regs)) { /* |