diff options
| author | Thadeu Lima de Souza Cascardo <cascardo@redhat.com> | 2016-04-01 17:17:50 -0300 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2016-05-01 00:06:08 +0200 |
| commit | 9d37d0bd4c8eb426660a2a86bba9af54c1be66e3 (patch) | |
| tree | 3f0ad5dc92c6baef40317361ccb9da9102eb72db | |
| parent | 9f9aecbffb51c330a7f134ddc5f22ce764b31210 (diff) | |
| download | lwn-9d37d0bd4c8eb426660a2a86bba9af54c1be66e3.tar.gz lwn-9d37d0bd4c8eb426660a2a86bba9af54c1be66e3.zip | |
ip6_tunnel: set rtnl_link_ops before calling register_netdevice
commit b6ee376cb0b7fb4e7e07d6cd248bd40436fb9ba6 upstream.
When creating an ip6tnl tunnel with ip tunnel, rtnl_link_ops is not set
before ip6_tnl_create2 is called. When register_netdevice is called, there
is no linkinfo attribute in the NEWLINK message because of that.
Setting rtnl_link_ops before calling register_netdevice fixes that.
Fixes: 0b112457229d ("ip6tnl: add support of link creation via rtnl")
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | net/ipv6/ip6_tunnel.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index 9fd04fff7fea..e9399e5c1709 100644 --- a/net/ipv6/ip6_tunnel.c +++ b/net/ipv6/ip6_tunnel.c @@ -273,12 +273,12 @@ static int ip6_tnl_create2(struct net_device *dev) t = netdev_priv(dev); + dev->rtnl_link_ops = &ip6_link_ops; err = register_netdevice(dev); if (err < 0) goto out; strcpy(t->parms.name, dev->name); - dev->rtnl_link_ops = &ip6_link_ops; dev_hold(dev); ip6_tnl_link(ip6n, t); |