summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric Sesterhenn <snakebyte@gmx.de>2006-09-29 02:01:32 -0700
committerLinus Torvalds <torvalds@g5.osdl.org>2006-09-29 09:18:23 -0700
commit8c6ba51bdad0de0dc2a2e2415d4dac2d0db6c1a1 (patch)
tree83727f2519978147ff509787ad6cb25379dd2cfd
parent04b1db9fd7eea63c9663072feece616ea41b0a79 (diff)
downloadlwn-8c6ba51bdad0de0dc2a2e2415d4dac2d0db6c1a1.tar.gz
lwn-8c6ba51bdad0de0dc2a2e2415d4dac2d0db6c1a1.zip
[PATCH] Uninitialized variable in drivers/net/wan/syncppp.c
For len equal to 4, we never call sppp_lcp_conf_parse_options(), therefore rmagic does not get initialized. Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de> Acked-by: Paul Fulghum <paulkf@microgate.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--drivers/net/wan/syncppp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wan/syncppp.c b/drivers/net/wan/syncppp.c
index d1173089f334..218f7b574ab3 100644
--- a/drivers/net/wan/syncppp.c
+++ b/drivers/net/wan/syncppp.c
@@ -469,7 +469,7 @@ static void sppp_lcp_input (struct sppp *sp, struct sk_buff *skb)
struct net_device *dev = sp->pp_if;
int len = skb->len;
u8 *p, opt[6];
- u32 rmagic;
+ u32 rmagic = 0;
if (!pskb_may_pull(skb, sizeof(struct lcp_header))) {
if (sp->pp_flags & PP_DEBUG)