diff options
| author | Jan Willeke <willeke@de.ibm.com> | 2014-07-22 16:50:57 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-07-27 09:55:51 -0700 |
| commit | 5704f30095a25fe215337d9689792c6531fa8b30 (patch) | |
| tree | 0cbc794d9c1cbbe0156906c42b2a1aee74db0a2c | |
| parent | d5ec9cb62fa916687ef726f16c604f94350ff71d (diff) | |
| download | lwn-5704f30095a25fe215337d9689792c6531fa8b30.tar.gz lwn-5704f30095a25fe215337d9689792c6531fa8b30.zip | |
s390/seccomp: fix error return for filtered system calls
commit dc295880c6752076f8b94ba3885d0bfff09e3e82 upstream.
The syscall_set_return_value function of s390 negates the error argument
before storing the value to the return register gpr2. This is incorrect,
the seccomp code already passes the negative error value.
Store the unmodified error value to gpr2.
Signed-off-by: Jan Willeke <willeke@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | arch/s390/include/asm/syscall.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/s390/include/asm/syscall.h b/arch/s390/include/asm/syscall.h index cd29d2f4e4f3..749313b452ae 100644 --- a/arch/s390/include/asm/syscall.h +++ b/arch/s390/include/asm/syscall.h @@ -54,7 +54,7 @@ static inline void syscall_set_return_value(struct task_struct *task, struct pt_regs *regs, int error, long val) { - regs->gprs[2] = error ? -error : val; + regs->gprs[2] = error ? error : val; } static inline void syscall_get_arguments(struct task_struct *task, |